[Mlir-commits] [mlir] [mlir][vector] Remove remaining bitwidths from linearization patterns (PR #138072)
James Newling
llvmlistbot at llvm.org
Thu May 1 08:54:21 PDT 2025
newling wrote:
> > Not sure if should just land PRs like this without waiting for a review (thoughts @banach-space ?)
>
> I’d land without review for obvious or trivial fixes - or when addressing a buildbot failure - and I think this PR falls into that category.
>
> Adding a short justification in the summary helps too (e.g., "This is straightforward and was requested in #NNNNNN, so landing without review.")
>
> Personally, I prefer getting an approval before merging, but reviewers are often busy, and reducing PR noise can sometimes be the more practical choice.
>
> That said, there’s an ongoing discussion on Discourse around post-commit review, which leans toward encouraging reviews for all patches - even smaller ones:
>
> * https://discourse.llvm.org/t/how-are-we-doing-post-commit-review/
Good advice, thanks! As for the thread -- I can't think of a real advantage/motivation for not first creating a PR.
https://github.com/llvm/llvm-project/pull/138072
More information about the Mlir-commits
mailing list