[Mlir-commits] [mlir] [mlir][spirv] Verify matching of entry block arguments and function signature (PR #133167)

[Jakub Kuderski]

================
@@ -1021,6 +1021,25 @@ LogicalResult spirv::FuncOp::verifyType() {
 
 LogicalResult spirv::FuncOp::verifyBody() {
   FunctionType fnType = getFunctionType();
+  if (!isExternal()) {
+    Block &entryBlock = front();
+
+    unsigned numArguments = this->getNumArguments();
+    if (entryBlock.getNumArguments() != numArguments)
+      return emitOpError("entry block must have ")
+             << numArguments << " arguments to match function signature";
+
+    ArrayRef<Type> fnInputTypes = getArgumentTypes();
+    for (unsigned i = 0, e = numArguments; i != e; ++i) {
+      Type argType = entryBlock.getArgument(i).getType();
----------------
kuhar wrote:

I think you should be able to use `for (auto [index, fnArgType, blockArgType] : llvm::enumerate(getArgumentType(), entryBlock.getArgumentTypes()))`

https://github.com/llvm/llvm-project/pull/133167