[Mlir-commits] [mlir] [mlir][spirv] Allow yielding values from selection regions (PR #133702)

[Jakub Kuderski]

================
@@ -227,11 +227,11 @@ struct IfOpConversion : SCFToSPIRVPattern<scf::IfOp> {
 
     // Create `spirv.selection` operation, selection header block and merge
     // block.
-    auto selectionOp =
-        rewriter.create<spirv::SelectionOp>(loc, spirv::SelectionControl::None);
+    auto selectionOp = rewriter.create<spirv::SelectionOp>(
+        loc, TypeRange(), spirv::SelectionControl::None);
     auto *mergeBlock = rewriter.createBlock(&selectionOp.getBody(),
                                             selectionOp.getBody().end());
-    rewriter.create<spirv::MergeOp>(loc);
+    rewriter.create<spirv::MergeOp>(loc, ValueRange());
----------------
kuhar wrote:

Maybe we can add builders that handle the no-result case?

https://github.com/llvm/llvm-project/pull/133702