[Mlir-commits] [mlir] [mlir][mpi] Mandatory Communicator (PR #133280)

[Christian Ulmann]

Sergio =?utf-8?q?S=C3=A1nchez_Ram=C3=ADrez?=,
Sergio =?utf-8?q?S=C3=A1nchez_Ram=C3=ADrez?=,
Sergio =?utf-8?q?S=C3=A1nchez_Ram=C3=ADrez?=,
Sergio =?utf-8?q?S=C3=A1nchez_Ram=C3=ADrez?=,
Sergio =?utf-8?q?S=C3=A1nchez_Ram=C3=ADrez?=,"Schlimbach, Frank"
 <frank.schlimbach at intel.com>,"Schlimbach, Frank" <frank.schlimbach at intel.com>
 =?utf-8?q?=2C?=Frank Schlimbach <frank.schlimbach at intel.com>,Frank
 Schlimbach <frank.schlimbach at intel.com>,"Schlimbach, Frank"
 <frank.schlimbach at intel.com>,"Schlimbach, Frank" <frank.schlimbach at intel.com>
 =?utf-8?q?=2C?="Schlimbach, Frank" <frank.schlimbach at intel.com>,Schlimbach,
 Frank <frank.schlimbach at intel.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/133280 at github.com>


================
@@ -83,9 +83,17 @@ class MPIImplTraits {
   ModuleOp &getModuleOp() { return moduleOp; }
 
   /// Gets or creates MPI_COMM_WORLD as a Value.
+  /// Different MPI implementations have different types for communicator.
+  /// Using i64 as a portable, intermediate type.
+  /// Appropriate cast needs to take place before calling MPI functions.
   virtual Value getCommWorld(const Location loc,
                              ConversionPatternRewriter &rewriter) = 0;
 
+  /// Type converter provides i64 type for communicator type.
+  /// Converts to native type, which  might be ptr or int or whatever.
----------------
Dinistro wrote:

```suggestion
  /// Converts to native type, which might be ptr or int or whatever.
```

https://github.com/llvm/llvm-project/pull/133280