[Mlir-commits] [mlir] [mlir][nvgpu] update commit group and wait async ops (PR #130482)

[Guray Ozen]

grypp wrote:

> As n gets larger, the parameters to be iterated in the loop increase linearly.But it's not really necessary to introduce the result of the commit_group in the loop.This made it more difficult for me to codegen gpu code.


So, you're saying that generating iter_args for the token is difficult. However, I don't find it challenging to generate iter_args. When it's lowered, there's no downside because it results in the same PTX, whether using the current approach or the proposed one.


I think it’s better to focus on whether the current approach actually blocks you.



https://github.com/llvm/llvm-project/pull/130482