[Mlir-commits] [mlir] [mlir][llvm] Add `LLVM_DependentLibrariesAttr` (PR #133385)

[Tobias Gysi]

================
@@ -2036,6 +2036,22 @@ LogicalResult ModuleTranslation::createCommandlineMetadata() {
   return success();
 }
 
+LogicalResult ModuleTranslation::createDependentLibrariesMetadata() {
+  if (auto dependentLibrariesAttr = mlirModule->getDiscardableAttr(
+          LLVM::LLVMDialect::getDependentLibrariesAttrName())) {
+    auto *nmd =
+        llvmModule->getOrInsertNamedMetadata("llvm.dependent-libraries");
+    llvm::LLVMContext &ctx = llvmModule->getContext();
+    for (auto lib : cast<ArrayAttr>(dependentLibrariesAttr)) {
----------------
gysit wrote:

```suggestion
    for (auto libAttr : dependentLibrariesAttr.getAsRange<StringAttr>()) {
```
nit: +-This should iterate over the string attributes directly.

https://github.com/llvm/llvm-project/pull/133385