[Mlir-commits] [mlir] Print region argument only when argAttrs are present (PR #133167)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: AdityaK (hiraditya)

<details>
<summary>Changes</summary>

Fixes: #<!-- -->132894

---
Full diff: https://github.com/llvm/llvm-project/pull/133167.diff


2 Files Affected:

- (modified) mlir/lib/Interfaces/CallInterfaces.cpp (+3-2) 
- (added) mlir/test/mlir-opt/print-region.mlir (+17) 


``````````diff
diff --git a/mlir/lib/Interfaces/CallInterfaces.cpp b/mlir/lib/Interfaces/CallInterfaces.cpp
index e8ed4b339a0cb..815b906d7d0f2 100644
--- a/mlir/lib/Interfaces/CallInterfaces.cpp
+++ b/mlir/lib/Interfaces/CallInterfaces.cpp
@@ -116,9 +116,10 @@ void call_interface_impl::printFunctionSignature(
 
     if (!isExternal) {
       ArrayRef<NamedAttribute> attrs;
-      if (argAttrs)
+      if (argAttrs) {
         attrs = llvm::cast<DictionaryAttr>(argAttrs[i]).getValue();
-      p.printRegionArgument(body->getArgument(i), attrs);
+        p.printRegionArgument(body->getArgument(i), attrs);
+      }
     } else {
       p.printType(argTypes[i]);
       if (argAttrs)
diff --git a/mlir/test/mlir-opt/print-region.mlir b/mlir/test/mlir-opt/print-region.mlir
new file mode 100644
index 0000000000000..678457defff57
--- /dev/null
+++ b/mlir/test/mlir-opt/print-region.mlir
@@ -0,0 +1,17 @@
+// Bug: https://github.com/llvm/llvm-project/issues/132894
+
+// RUN: mlir-opt %s | FileCheck
+
+// CHECK: module {
+// CHECK:   spirv.func @f(f32) "None" {
+// CHECK:     %c0 = arith.constant 0 : index
+// CHECK:     spirv.Return
+// CHECK:   }
+// CHECK: }
+
+module {
+  spirv.func @f(f32) "None" {
+    %c0 = arith.constant 0 : index
+    spirv.Return
+  }
+}

``````````

</details>


https://github.com/llvm/llvm-project/pull/133167