[Mlir-commits] [mlir] [mlir][gpu][nvptx] Remove null terminator when outputting PTX (PR #133019)

[Mehdi Amini]

joker-eph wrote:

If this is about `ptxas` then the fix may rather be at the point where we call `ptxas`. We have to write this down to a file somehow to pass it to `ptxas` and this is where we write an extra null character to the file. 

Here is how we prepare the input to ptxas: https://github.com/llvm/llvm-project/blob/1c9fe8c8af7e473e37e141d36837d196dd9a5256/mlir/lib/Target/LLVM/NVVM/Target.cpp#L390-L403

It's not clear to me why there would be the extra null character in the file though?

https://github.com/llvm/llvm-project/pull/133019