[Mlir-commits] [mlir] [MLIR][Linalg] Fix insert_slice fusion with rank reduction (PR #130961)

[Andrzej Warzyński]

================
@@ -235,6 +237,39 @@ mlir::linalg::fuseProducerOfTensor(OpBuilder &b, OpOperand &consumerOpOperand) {
   return fuseProducerOfTensor(b, producerOpResult, consumerOpOperand);
 }
 
+/// Create tensor.collapse_shape to drop dimensions in `dropDims` in tensor
+/// `from`.
----------------
banach-space wrote:

Since this is only used for dropping unit dims ("rank reducing extract slice"), I would make that clear and also add an assert. Generalise is fine, but then we should test more.

https://github.com/llvm/llvm-project/pull/130961