[Mlir-commits] [mlir] [mlir] DistinctAttributeAllocator: fix race (PR #132935)

[Tobias Gysi]

gysit wrote:

> But it seems like disableThreadLocalStorage is called from multi-thread code? Would introducing a lock in disableThreadLocalStorage avoid the problem as well?

Note to myself. Locking probably does not help since `PassManager::runWithCrashRecovery` executes in parallel and we want to disable thread local storage whenever at least some pass manager with crash recovery is running.

I guess given this additional complication it may make sense to fall back to a bump pointer allocator & locking.

https://github.com/llvm/llvm-project/pull/132935