[Mlir-commits] [mlir] [mlir] DistinctAttributeAllocator: fix race (PR #132935)

[Tobias Gysi]

https://github.com/gysit approved this pull request.

LGTM

I am fine if this fixes the immediate problem. However, as you wrote on the other PR the solution defeats the purpose of avoiding lock contention. 

When reviewing I was under the impression that we can check this flags safely since they are only set in single-thread code (for enable/disable multi-threading this is probably the case). But it seems like `disableThreadLocalStorage` is called from multi-thread code? Would introducing a lock in `disableThreadLocalStorage` avoid the problem as well?

https://github.com/llvm/llvm-project/pull/132935