[Mlir-commits] [mlir] [mlir][vector] Decouple unrolling gather and gather to llvm lowering (PR #132206)

[Kunwar Grover]

================
@@ -269,49 +269,32 @@ class VectorGatherOpConversion
     if (failed(isMemRefTypeSupported(memRefType, *this->getTypeConverter())))
       return failure();
 
+    VectorType vType = gather.getVectorType();
+    if (vType.getRank() > 1)
+      return failure();
+
     auto loc = gather->getLoc();
 
     // Resolve alignment.
     unsigned align;
     if (failed(getMemRefAlignment(*getTypeConverter(), memRefType, align)))
       return failure();
 
+    // Resolve address.
----------------
Groverkss wrote:

I'm mainly trying to match exactly the scatter conversion logic. To keep them same, I'm opting for "Resolve address" for now. I've cleaned it up to not have duplicating address resolution comments.

https://github.com/llvm/llvm-project/pull/132206