[Mlir-commits] [mlir] [mlir][vector] Allow multi dim vectors in vector.scatter (PR #132217)

[Andrzej Warzyński]

banach-space wrote:

Hi Kunwar,

Thanks for updating the PR with the Discourse link — that definitely helps clarify the context and dependencies. And no worries about the format; I appreciate your flexibility on whether to use a GitHub issue, Graphite, or Discourse.

Also, apologies — I missed the note below the summary referencing the other PR. That was my oversight; I scrolled past it too quickly.

As you can see from the PRs I linked, contributors often mention dependencies directly in the PR summary. That’s where I was expecting to find it too, but clearly there’s no consistent practice yet. To help with standardization and reduce this kind of confusion in the future, I’ve submitted:
* https://github.com/llvm/llvm-project/pull/132424

Hopefully once that lands, it’ll make things clearer for both authors and reviewers.

One additional note, directed more generally to the thread: some earlier phrasing (e.g., referring to a suggestion as “utterly useless”) felt unnecessarily dismissive. While I’m sure no harm was intended, I want to remind everyone that LLVM’s [Code of Conduct](https://llvm.org/docs/CodeOfConduct.html) encourages us to keep discussions professional and respectful, even when we disagree. That’s essential for keeping the project collaborative and welcoming for all contributors.

Thanks again — looking forward to reviewing the next PRs in the stack!

https://github.com/llvm/llvm-project/pull/132217