[Mlir-commits] [mlir] [mlir][vector] Allow multi dim vectors in vector.scatter (PR #132217)

[Kunwar Grover]

================
@@ -1719,6 +1719,40 @@ func.func @gather_with_zero_mask_scalable(%arg0: memref<?xf32>, %arg1: vector<2x
 
 // -----
 
+//===----------------------------------------------------------------------===//
+// vector.scatter
+//===----------------------------------------------------------------------===//
----------------
Groverkss wrote:

> Do these qualify as "complex tests"

Yes they do. vector-to-llvm-interface tests do not include any preprocessing. We need preprocessing to unroll multi dimensional scatters. This is exactly same as gather, we are being consistent.

> Also, given that these are "negative" tests, we could label them accordingly:

Sure I will change it. They are anyway going to become positive test in the next pr in the stack: https://github.com/llvm/llvm-project/pull/132227

https://github.com/llvm/llvm-project/pull/132217