[Mlir-commits] [mlir] [mlir] Decouple enum generation from attributes, adding EnumInfo and EnumCase (PR #132148)
Matthias Springer
llvmlistbot at llvm.org
Fri Mar 21 03:05:07 PDT 2025
matthias-springer wrote:
Thx for breaking up the PR. It's still quite large, maybe this could also be a separate one:
```
In addition, the new BitEnum class changes its default printer/parser behavior: cases when multiple keywords appear, like having both nuw and nsw in overflow flags, will no longer be quoted by the operator<<, and the FieldParser instance will now expect multiple keywords. All instances of BitEnumAttr retain the old behavior.
```
Or maybe the part that moves code to `EnumInfo.h`.
In my experience, anything that's larger than 100 loc is taking a quite long time to get reviewed...
https://github.com/llvm/llvm-project/pull/132148
More information about the Mlir-commits
mailing list