https://github.com/banach-space commented: This is looking good. I've left a couple of minor comments. I need to take another look, but I am unlikely to ask for anything major, this looks quite polished. https://github.com/llvm/llvm-project/pull/131982