[Mlir-commits] [mlir] [MLIR][NVVM] Add support for st.bulk Op (PR #131727)

[Mehdi Amini]

================
@@ -125,6 +125,14 @@ llvm.func @convert_float_to_tf32_no_rnd_mode(%src : f32) -> i32 {
 
 // -----
 
+llvm.func @nvvm_st_bulk_initval_nonzero(%addr : !llvm.ptr, %size : i64) {
+  // expected-error @below {{only 0 is supported for initVal in st.bulk}}
+  nvvm.st.bulk %addr, %size, 1 : !llvm.ptr
----------------
joker-eph wrote:

What about a more explicit syntax (the SSA names would likely not be expressive like here)
```suggestion
  nvvm.st.bulk %arg0 size = %arg1 init = 1 : !llvm.ptr
```
or

```suggestion
  nvvm.st.bulk %arg0[%arg1] = 1 : !llvm.ptr
```

Also a making 0 the default value for the attribute would allow to elide the `init` printing when `0` (which is the expected case anyway).



https://github.com/llvm/llvm-project/pull/131727