[Mlir-commits] [mlir] [mlir] Fix edge case in move operation dependencies utility (PR #131081)

[llvmlistbot at llvm.org]

https://github.com/MaheshRavishankar requested changes to this pull request.

Yeah, this change makes sense overall, but there are a couple of issues that I think we would rather do. The reason I added the separate path for `moveValueDefinitions` is for such cases. This path will
1) Compute different slices for each `Value`
2) Do a topological sort for the combined slice
This is overhead that we can avoid by changing the `getBackwardSlice` to compute slices with multiple `Value`s. I havent looked into the implementation, but I think seeding the worklist with multiple `Value`s "should" do this. With that we can avoid both these overheads. It would be good to fix the slice implementation first before this change.

Marking this as Request changes for now.

https://github.com/llvm/llvm-project/pull/131081