[Mlir-commits] [mlir] [MLIR][NFC] Retire let constructor for Bufferization (PR #129850)

[Mehdi Amini]

================
@@ -63,11 +63,9 @@ parseHeuristicOption(const std::string &s) {
 }
 
 struct OneShotBufferizePass
-    : public bufferization::impl::OneShotBufferizeBase<OneShotBufferizePass> {
-  OneShotBufferizePass() = default;
-
-  explicit OneShotBufferizePass(const OneShotBufferizationOptions &options)
----------------
joker-eph wrote:

You can't really "subclass" a pass, you need to create your own pass on the model of the upstream one somehow, and call `runOneShotModuleBufferize()` yourself with the options that fit your need.

If there is some logic in the pass that should be shared, we can refactor the pass implementation to expose these utilities (and keep the pass itself a thin shim plumbing the command line option to the C++ `runOneShotModuleBufferize()` call)

https://github.com/llvm/llvm-project/pull/129850