[Mlir-commits] [mlir] [MLIR][NFC] Retire let constructor for Bufferization (PR #129850)

Mehdi Amini llvmlistbot at llvm.org
Tue Mar 18 04:05:07 PDT 2025


================
@@ -63,11 +63,9 @@ parseHeuristicOption(const std::string &s) {
 }
 
 struct OneShotBufferizePass
-    : public bufferization::impl::OneShotBufferizeBase<OneShotBufferizePass> {
-  OneShotBufferizePass() = default;
-
-  explicit OneShotBufferizePass(const OneShotBufferizationOptions &options)
----------------
joker-eph wrote:

> Can we please get a constructor back that allows to pass mlir::bufferization::OneShotBufferizationOptions?

I would rather not: this is a hole in the system, the missing options you noticed are an indication of the problem, these wouldn't have been serialized in a round-trip of the pass-manager for example (if I followed correctly what you're pointing at).

https://github.com/llvm/llvm-project/pull/129850


More information about the Mlir-commits mailing list