[Mlir-commits] [mlir] [MLIR][NFC] Retire let constructor for Bufferization (PR #129850)

[Adrian Kuegel]

================
@@ -63,11 +63,9 @@ parseHeuristicOption(const std::string &s) {
 }
 
 struct OneShotBufferizePass
-    : public bufferization::impl::OneShotBufferizeBase<OneShotBufferizePass> {
-  OneShotBufferizePass() = default;
-
-  explicit OneShotBufferizePass(const OneShotBufferizationOptions &options)
----------------
akuegel wrote:

It turns out we do actually need more options:
```
allocationFn
memCpyFn
functionArgTypeConverterFn
inferFunctionResultLayout
```

Also, using mlir::bufferization::OneShotBufferizationOptions is somewhat better as it guards against typos. For example if you want to pass functionBoundaryTypeConversion, with the tablegen options it is just a string. With mlir::bufferization::OneShotBufferizationOptions it is an enum.

Can we please get a constructor back that allows to pass mlir::bufferization::OneShotBufferizationOptions?

https://github.com/llvm/llvm-project/pull/129850