[Mlir-commits] [mlir] [mlir] Use `getSingleElement`/`hasSingleElement` in various places (PR #131460)

[David Blaikie]

dwblaikie wrote:

> > yes - I'd argue that even the simple wrappers could/should be tested,
> 
> Right, the question is what is the bar for "tested". For every other kind of utilities, having enough in-tree uses counts as "tested" (we don't have C++ gtests for every possible utility functions historically).

Sorry, I meant unit tested in this context/case. For things in ADT/STLExtras - yes, we don't, historically, have full coverage - but as the project's gotten larger I think it's become more relevant to test them in isolation more robustly (so that they're tested even when the only uses are in some non-LLVM subproject, so that they're tested robustly regardless of which use cases we have/don't have in-tree at any given moment, etc).

https://github.com/llvm/llvm-project/pull/131460