[Mlir-commits] [llvm] [mlir] [llvm] Add `getSingleElement` helper and use in MLIR (PR #131460)

Jakub Kuderski llvmlistbot at llvm.org
Sat Mar 15 19:29:25 PDT 2025


https://github.com/kuhar requested changes to this pull request.

For STLExtras changes, we typically require unit tests and land the change that introduces uses as a follow up PR. This is to minimize the risk of reverts that cause a full project rebuild. Could you split this PR into two?

For as for unit tests, we don't need anything fancy beyond making sure this works with a couple of data types and const / lvalue / rvalue parameters. We could also add a death test for the assertion. 

https://github.com/llvm/llvm-project/pull/131460


More information about the Mlir-commits mailing list