[Mlir-commits] [mlir] [mlir][Transforms] Dialect Conversion: Add 1:N support to `remapInput` (PR #131454)

Markus Böck llvmlistbot at llvm.org
Sat Mar 15 07:32:31 PDT 2025


================
@@ -92,9 +95,9 @@ class TypeConverter {
     /// used if the new types are not intended to remap an existing input.
     void addInputs(ArrayRef<Type> types);
 
-    /// Remap an input of the original signature to another `replacement`
+    /// Remap an input of the original signature to another `replacements`
     /// value. This drops the original argument.
-    void remapInput(unsigned origInputNo, Value replacement);
+    void remapInput(unsigned origInputNo, ArrayRef<Value> replacements);
----------------
zero9178 wrote:

```suggestion
    void remapInput(unsigned origInputNo, ValueRange replacements);
```
Not sure this makes a large difference for most callers, but I would prefer `ValueRange` over `ArrayRef` generally speaking

https://github.com/llvm/llvm-project/pull/131454


More information about the Mlir-commits mailing list