[Mlir-commits] [mlir] [NFC] fix msvc debug build errors (PR #131393)
Bangtian Liu
llvmlistbot at llvm.org
Fri Mar 14 14:16:02 PDT 2025
https://github.com/bangtianliu created https://github.com/llvm/llvm-project/pull/131393
We found the build broken using msvc debug build as below:
```
C:\Users\bangtliu\iree\third_party\llvm-project\llvm\include\llvm/ADT/SmallVector.h(1162): error C2338: static_assert failed: 'You are trying to use a default number of inlined elements for `SmallVector<T>` but `sizeof(T)` is really big! Please use an explicit number of inlined elements with `SmallVector<T, N>` to make sure you really want that much inline storage.'
C:\Users\bangtliu\iree\third_party\llvm-project\llvm\include\llvm/ADT/SmallVector.h(1162): note: the template instantiation context (the oldest one first) is
C:\Users\bangtliu\iree\third_party\llvm-project\llvm\include\llvm/ADT/SmallVector.h(1194): note: see reference to class template instantiation 'llvm::CalculateSmallVectorDefaultInlinedElements<T>' being compiled
with
[
T=`anonymous-namespace'::LinalgOperandDef
]
C:\Users\bangtliu\iree\third_party\llvm-project\mlir\tools\mlir-linalg-ods-gen\mlir-linalg-ods-yaml-gen.cpp(120): error C2976: 'llvm::SmallVector': too few template arguments
C:\Users\bangtliu\iree\third_party\llvm-project\llvm\include\llvm/ADT/SmallVector.h(1195): note: see declaration of 'llvm::SmallVector'
[862/7776] Building CXX object llvm-project\lib\DebugInfo\DWARF\CMakeFiles\LLVMDebugInfoDWARF.dir\DWARFDebugLine.cpp.obj
ninja: build stopped: subcommand failed.
```
This PR is added to address this error.
>From 8ba8c713e78dd27caf3d691b78230b6f7af7ef13 Mon Sep 17 00:00:00 2001
From: Bangtian Liu <liubangtian at gmail.com>
Date: Fri, 14 Mar 2025 16:13:05 -0500
Subject: [PATCH] fix msvc debug build errors
Signed-off-by: Bangtian Liu <liubangtian at gmail.com>
---
mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp b/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
index 80d979864921d..93a300e0b24a2 100644
--- a/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
+++ b/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
@@ -117,9 +117,9 @@ struct ScalarAssign {
};
struct LinalgStructuredOpConfig {
- SmallVector<LinalgOperandDef> args;
+ SmallVector<LinalgOperandDef, 4> args;
LinalgIndexingMapsConfig indexingMaps;
- SmallVector<LinalgIteratorTypeDef> iteratorTypes;
+ SmallVector<LinalgIteratorTypeDef, 4> iteratorTypes;
std::vector<ScalarAssign> assignments;
};
More information about the Mlir-commits
mailing list