[Mlir-commits] [mlir] [MLIR][Bufferization] Retire `enforce-aliasing-invariants` (PR #130929)

[lorenzo chelini]

chelini wrote:

> The comment here is
> 
> ```
> Note: Deactivating this flag can lead to incorrect bufferization results
> when used incorrectly. This flag is useful with
> `AlwaysCopyAnalysisState` which bufferizes all writing tensor
> OpOperands out-of-place.
> ```
> 
> It is not clear what "used" incorrectly is. The existing default is for this to be `true`. I feel like this might uncover other bugs in bufferization that isnt being caught by upstream tests. There is definitely an correctness issue here, but this might be too big a hammer. Do we want to do a PSA before hand cause this can be a breaking change and I am fraid about the coverage upstream.
> 
> Also what will happen if `copyBeforeWrite` is set to `true`.

I also ran the IREE unit tests and didn’t encounter any failures. I agree with Matthias—the option is always used in tandem with copy-before-write, so we can safely remove it. Can you please run IREE pipeline on this commit?

https://github.com/llvm/llvm-project/pull/130929