[Mlir-commits] [mlir] [mlir][emitc] mark `emitc.load` with `CExpression` (PR #130802)

[Kirill Chibisov]

kchibisov wrote:

>Can you please add some tests for the output of translation? Interesting test case could also be loading from an array index,

Sure done.

>and then either having the emitc.subscript also within the CExpression or outside

`emitc.subscript` is not a `CExpression`.

>On top of that a translation test with a combination of a load inside an expression and a call_opaque op would be useful. I'm not sure if the precedence shouldn't be higher than that of any other op.

Sure, done. If it's not what you've expected, let me know.

https://github.com/llvm/llvm-project/pull/130802