[Mlir-commits] [mlir] [mlir][tosa] Align Variable ops to match with TOSA v1.0 spec (PR #130680)

[Luke Hutton]

================
@@ -86,12 +86,13 @@ def Tosa_VariableOp : Tosa_Op<"variable", []> {
   let summary = "Defines a variable";
 
   let description = [{
-    Defines a new TOSA variable. This is a mutable value.
+    Defines a new TOSA variable.
+    This is a persistent mutable value across multiple TOSA graph invocations.
     Modifications are expressed using read/write semantics.
   }];
 
   let arguments = (ins
-    SymbolNameAttr:$name,
+    SymbolNameAttr:$uid,
----------------
lhutton1 wrote:

I wonder if it would be worth leaving a comment here to explain why there's divergence from the spec?

Also, since we're choosing to use a name rather than uid, I'm wondering if "name" was actually better name for the attribute (apologies for the back-and-forth on this, would be good to see what @GeorgeARM thinks before making the change)? 

https://github.com/llvm/llvm-project/pull/130680