[Mlir-commits] [mlir] [MLIR][NFC] Adding a missing option in OneShotBufferizePass (PR #130691)

[lorenzo chelini]

chelini wrote:

> > Can we get some?
> 
> To be fair most (if not all) of those options in the bufferization passes do not have corresponding tests, so #129850 skipped a lot of checks and got merged. If we want tests we would need to also cover all those. But historically no tests were in place, and adding tests is beyond the scope of this quick patch, and requires some coordination.
> 
> Our downstream does require to set this specific option, so this is just a quick patch to unblock downstream.

I don’t think #129850 “skipped a lot of checks.” The issue isn’t with #129850 itself but rather the lack of testing for options. I did not check this pass option yet, so I don't know how hard it is to add a test, but I will do it tomorrow. 

https://github.com/llvm/llvm-project/pull/130691