[Mlir-commits] [mlir] [MLIR][LLVMIR] Import: add flag to prefer using unregistered intrinsics (PR #130685)

[Bruno Cardoso Lopes]

bcardosolopes wrote:

> I think we need to put a fat warning on the flag since this may fail if passes rely on detecting the explicit intrinsic operation.

Hmm, we might want to use LLVM IR without the supported intrinsics in production (i.e. not only for testing) - in which case the warning feels like a constant annoyance / misleading. Should I introduce an extra flag for controlling such warning?

> I also wonder if we should move the handling of the unregistered intrinsics in ModuleImport? 

Hmm, while working on the PR that added the unregistered intrinsics you asked similar and I couldn't easily make it happen - there were complications in the interaction between querying other dialects via interfaces along side the fallback mechanism which is LLVM dialect only. It's probably possible but might need moving enough pieces around that should be done in its own PR.

https://github.com/llvm/llvm-project/pull/130685