[Mlir-commits] [mlir] [MLIR][LLVMIR] Add module flags support (PR #130679)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff cb3ce30ca813b4158b93756e465fa0afe71bfc49 f377077b330be7cad03c942977cd151f73eee63b --extensions cpp,h -- mlir/include/mlir/Target/LLVMIR/ModuleImport.h mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp mlir/lib/Target/LLVMIR/ModuleImport.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp b/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
index f29b08b4f7..589c5b1287 100644
--- a/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
@@ -277,9 +277,10 @@ static void convertModuleFlagsOp(ArrayAttr flags, llvm::IRBuilderBase &builder,
     auto flag = cast<ModuleFlagAttr>(attr);
     auto intVal = dyn_cast<IntegerAttr>(flag.getValue());
     assert(intVal && "expected integer attribute");
-    llvmModule->addModuleFlag(
-        static_cast<llvm::Module::ModFlagBehavior>(flag.getBehavior().getValue()),
-        flag.getKey().getValue(), (uint32_t)intVal.getUInt());
+    llvmModule->addModuleFlag(static_cast<llvm::Module::ModFlagBehavior>(
+                                  flag.getBehavior().getValue()),
+                              flag.getKey().getValue(),
+                              (uint32_t)intVal.getUInt());
   }
 }
 
diff --git a/mlir/lib/Target/LLVMIR/ModuleImport.cpp b/mlir/lib/Target/LLVMIR/ModuleImport.cpp
index b273ef7d21..c414ab21f0 100644
--- a/mlir/lib/Target/LLVMIR/ModuleImport.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleImport.cpp
@@ -543,9 +543,8 @@ LogicalResult ModuleImport::convertModuleFlagsMetadata() {
     ModFlagBehaviorAttr behaviorAttr = ModFlagBehaviorAttr::get(
         builder.getContext(), (ModFlagBehavior)behavior);
 
-    moduleFlags.push_back(
-        builder.getAttr<ModuleFlagAttr>(behaviorAttr, builder.getStringAttr(key->getString()),
-                                                                valAttr));
+    moduleFlags.push_back(builder.getAttr<ModuleFlagAttr>(
+        behaviorAttr, builder.getStringAttr(key->getString()), valAttr));
   }
 
   if (!moduleFlags.empty()) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/130679