[Mlir-commits] [mlir] [MLIR][OpenMP] Enable BlockArgOpenMPOpInterface accessing operands (PR #130769)

[Sergio Afonso]

================
@@ -629,12 +617,10 @@ class OpenMP_InReductionClauseSkip<
 
   let extraClassDeclaration = [{
     /// Returns the reduction variables.
-    SmallVector<Value> getReductionVars() {
+    SmallVector<Value> getAllReductionVars() {
----------------
skatrak wrote:

This has to do with the `ReductionClauseInterface`, which defines the `getAllReductionVars` function to consolidate all reduction-like clauses. So yes, reduction-like clauses are supposed to define this based on the reduction variables associated to that clause, and then operations accepting more than one kind of reduction-like clause are supposed to override that (`TaskloopOp` is the only case at the moment).

However, this interface is currently unused and I'm not convinced that it's terribly useful to have. I'd actually like to propose removing it as a follow-up patch (cc @kiranktp, @NimishMishra, @kiranchandramohan, @tblah).

https://github.com/llvm/llvm-project/pull/130769