[Mlir-commits] [mlir] [mlir][tosa] Align Variable ops to match with TOSA v1.0 spec (PR #130680)

Luke Hutton llvmlistbot at llvm.org
Tue Mar 11 07:13:28 PDT 2025


================
@@ -140,11 +141,11 @@ def Tosa_VariableReadOp : Tosa_Op<"variable.read", []> {
   let summary = "read_buffer operator";
 
   let description = [{
-    Reads the value from a pseudo-buffer resource holding a mutable tensor.
+    Reads the value from a pseudo-buffer resource holding a persistent mutable tensor.
   }];
 
   let arguments = (ins
-    SymbolNameAttr:$name
+    I32Attr:$uid
   );
 
   let results = (outs
----------------
lhutton1 wrote:

(github wouldn't let me leave a comment on the line below)

Should this be `TosaTensor: $output1` in accordance with the spec?

https://github.com/llvm/llvm-project/pull/130680


More information about the Mlir-commits mailing list