[Mlir-commits] [mlir] [flang][OpenMP] Translate OpenMP scopes when compiling for target device (PR #130078)

[Pranav Bhandarkar]

================
@@ -542,6 +542,18 @@ static llvm::omp::ProcBindKind getProcBindKind(omp::ClauseProcBindKind kind) {
   llvm_unreachable("Unknown ClauseProcBindKind kind");
 }
 
+/// Maps elements of \p blockArgs (which are MLIR values) to the corresponding
+/// LLVM values of \p operands' elements. This is useful when an OpenMP region
+/// with entry block arguments is converted to LLVM. In this case \p blockArgs
+/// are (part of) of the OpenMP region's entry arguments and \p operands are
+/// (part of) of the operands to the OpenMP op containing the region.
----------------
bhandarkar-pranav wrote:

MegaNit: Could you perhaps add a comment that makes it clear that `operands` are operands of an *enclosing* operation. Somethign like this might help
```
enclosing_op(operands)
{
 block(block_args)
}
```

https://github.com/llvm/llvm-project/pull/130078