[Mlir-commits] [mlir] [mlir] Add `SelectPass` (PR #130409)

[Jacques Pienaar]

jpienaar wrote:

> We played with the concept before but it's hard to make it really widely applicable: you quickly need a real language to express the condition beyond the simple "match an attribute to this exact value" that you demonstrate here

While true, this is also quite common. E.g., this mechanism is sufficient to replace many of the command line flags usage that is being threaded through rather ad hoc manner at the moment by multiple different teams. One could always have a "flatten to simple choice" pass that is specific to user and flattens complicated logic into simple attributes. That avoids needing a language in the selector as its in the pass. Yes, it just moves the complexity but there are many cases that don't need this complexity - at least not at the level of pass pipelines. Which is why I'm supportive (common enough, usable by multiple groups & simple).

https://github.com/llvm/llvm-project/pull/130409