[Mlir-commits] [mlir] [mlir][spirv] Add definition for selected sample operations (PR #129558)

[Andrea Faulds]

================
@@ -115,7 +121,7 @@ def SPIRV_ImageDrefGatherOp : SPIRV_Op<"ImageDrefGather",
 
   let assemblyFormat = [{
     $sampled_image `,` $coordinate `,` $dref custom<ImageOperands>($image_operands) ( `(` $operand_arguments^ `)` )? attr-dict 
-    `:` type($sampled_image) `,` type($coordinate) `,` type($dref) ( `(` type($operand_arguments)^ `)` )?
+    `:` type($sampled_image) `,` type($coordinate) `,` type($dref) ` ` ( `(` type($operand_arguments)^ `)` )?
----------------
andfau-amd wrote:

Oh, I see! Indeed I had to stare at the version without the space a few times to realise what you meant, because I read them coupled in just the way you were worried about. This seems reasonable to me then. Maybe someone else can comment if there is a better way to do this, but in the absence of better ideas I think this is fine.

https://github.com/llvm/llvm-project/pull/129558