[Mlir-commits] [mlir] [mlir][spirv] Add definition for selected sample operations (PR #129558)

[Igor Wodiany]

IgWod-IMG wrote:

> General comment: why these three specifically? I can understand the logic to adding just the plain implicit and explicit LoD operations, as they're maybe the two most common and simplest sampling operations, but I'm not sure why you would also add just one operation out of the whole dref and proj family at the same time. I guess we strictly speaking do not have to add the whole set at once, but the piecemealness of it feels a little strange to me.

There is a logic to this madness. We started using SPIR-V MLIR in a front-end of some of our internal research tools. So, what ops I add is driven by what content/benchmarks we are trying to support next. As it happens a set of shaders, I'm looking at now, needs those 3 image-related ops, so I decided to add them all in one go. Hope this make more sense now.

https://github.com/llvm/llvm-project/pull/129558