[Mlir-commits] [mlir] [mlir][spirv] Add definition for selected sample operations (PR #129558)

[Igor Wodiany]

================
@@ -51,10 +52,15 @@ class SPIRV_NoneOrElementMatchImage<string operand, string image, string transfo
   CPred<"::llvm::isa<NoneType>(cast<ImageType>(" # !subst("$_self", "$" # image # ".getType()", transform) # ").getElementType()) ||"
         "(getElementTypeOrSelf($" # operand # ")"
           "=="
-        "cast<ImageType>(" # !subst("$_self", "$" # image # ".getType()", transform) # ").getElementType())"
+        "cast<::mlir::spirv::ImageType>(" # !subst("$_self", "$" # image # ".getType()", transform) # ").getElementType())"
----------------
IgWod-IMG wrote:

It was an attempt to be more consistent as line 26 uses this format but looks like I missed line 52. I'm going to add `::mlir::spirv::` to line 52 and double check other types across the file. My intention starting with #128552 was to use `::mlir::spirv::` as it seems to be a common practice in `mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td`.

https://github.com/llvm/llvm-project/pull/129558