[Mlir-commits] [mlir] [mlir] Add `SelectPass` (PR #130409)

[Mehdi Amini]

https://github.com/joker-eph requested changes to this pull request.

This is seems quite an ad-hoc mechanism to me.

We played with the concept before but it's hard to make it really widely applicable: you quickly need a real language to express the condition beyond the simple "match an attribute to this exact value" that you demonstrate here. The value-add of a pass presented as "generic" instead of letting one implement their own pass for their use-case isn't totally clear to me right now.

https://github.com/llvm/llvm-project/pull/130409