[Mlir-commits] [mlir] [MLIR][LLVMIR] Translation: honor frame-pointer fn attribute (PR #130335)

[Tobias Gysi]

================
@@ -1606,6 +1606,9 @@ static void convertFunctionAttributes(LLVMFuncOp func,
     llvmFunc->addFnAttr(llvm::Attribute::NoUnwind);
   if (func.getWillReturnAttr())
     llvmFunc->addFnAttr(llvm::Attribute::WillReturn);
+  if (FramePointerKindAttr fpAttr = func.getFramePointerAttr())
----------------
gysit wrote:

There is already a translation of the frame pointer attribute in `convertOneFunction` which apparently only executes for function declarations and not for definitions.

Did you see it on declarations in real inputs? If yes then let's remove the frame pointer code from `convertOneFunction`. I think this function runs on both declarations and definitions.





https://github.com/llvm/llvm-project/pull/130335