[Mlir-commits] [mlir] [mlir][OpenMP] cast address space of private variables (PR #130301)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Fri Mar 7 09:49:53 PST 2025
https://github.com/agozillon approved this pull request.
This LGTM, I imagine we're allocating the private variable in the kernel in the alloca address space and then needing to cast it to the program address space for usage. Seems reasonable to me! Not too sure/can't comment on if there's anything special the AMDGPU backend needs for private variables though, I doubt it and I'm sure we'll find out soon enough if so though :-)
@jsjodin is also another good secondary reviewer if you want another pair of eyes
https://github.com/llvm/llvm-project/pull/130301
More information about the Mlir-commits
mailing list