[Mlir-commits] [mlir] [mlir][TOSA] Fix linalg lowering of depthwise conv2d (PR #130282)

[LLVM Continuous Integration]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `mlir` at step 7 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/24998

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 7 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'MLIR :: Conversion/TosaToLinalg/tosa-to-linalg-named.mlir' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/build/buildbot/premerge-monolithic-linux/build/bin/mlir-opt --verify-each --split-input-file -pass-pipeline="builtin.module(func.func(tosa-to-linalg-named))" /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir -verify-diagnostics -o -| /build/buildbot/premerge-monolithic-linux/build/bin/FileCheck /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir
# executed command: /build/buildbot/premerge-monolithic-linux/build/bin/mlir-opt --verify-each --split-input-file '-pass-pipeline=builtin.module(func.func(tosa-to-linalg-named))' /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir -verify-diagnostics -o -
# .---command stderr------------
# | <unknown>:0: error: unexpected error: expected integer or index type
# | mlir-opt: /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/include/mlir/IR/StorageUniquerSupport.h:180: static ConcreteT mlir::detail::StorageUserBase<mlir::IntegerAttr, mlir::Attribute, mlir::detail::IntegerAttrStorage, mlir::detail::AttributeUniquer, mlir::TypedAttr::Trait>::get(MLIRContext *, Args &&...) [ConcreteT = mlir::IntegerAttr, BaseT = mlir::Attribute, StorageT = mlir::detail::IntegerAttrStorage, UniquerT = mlir::detail::AttributeUniquer, Traits = <mlir::TypedAttr::Trait>, Args = <mlir::Type &, const llvm::APInt &>]: Assertion `succeeded( ConcreteT::verifyInvariants(getDefaultDiagnosticEmitFn(ctx), args...))' failed.
# | PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
# | Stack dump:
# | 0.	Program arguments: /build/buildbot/premerge-monolithic-linux/build/bin/mlir-opt --verify-each --split-input-file -pass-pipeline=builtin.module(func.func(tosa-to-linalg-named)) /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir -verify-diagnostics -o -
# |  #0 0x00005a50c46ce058 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/lib/Support/Unix/Signals.inc:804:13
# |  #1 0x00005a50c46cbb8e llvm::sys::RunSignalHandlers() /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/lib/Support/Signals.cpp:106:18
# |  #2 0x00005a50c46ce831 SignalHandler(int, siginfo_t*, void*) /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/lib/Support/Unix/Signals.inc:0:3
# |  #3 0x000078cda9680520 (/lib/x86_64-linux-gnu/libc.so.6+0x42520)
# |  #4 0x000078cda96d49fc pthread_kill (/lib/x86_64-linux-gnu/libc.so.6+0x969fc)
# |  #5 0x000078cda9680476 gsignal (/lib/x86_64-linux-gnu/libc.so.6+0x42476)
# |  #6 0x000078cda96667f3 abort (/lib/x86_64-linux-gnu/libc.so.6+0x287f3)
# |  #7 0x000078cda966671b (/lib/x86_64-linux-gnu/libc.so.6+0x2871b)
# |  #8 0x000078cda9677e96 (/lib/x86_64-linux-gnu/libc.so.6+0x39e96)
# |  #9 0x00005a50c7872a00 mlir::IntegerAttr::getChecked(llvm::function_ref<mlir::InFlightDiagnostic ()>, mlir::Type, llvm::APInt const&) /build/buildbot/premerge-monolithic-linux/build/tools/mlir/include/mlir/IR/BuiltinAttributes.cpp.inc:374:0
# | #10 0x00005a50c7872882 mlir::IntegerAttr::get(mlir::Type, llvm::APInt const&) /build/buildbot/premerge-monolithic-linux/build/tools/mlir/include/mlir/IR/BuiltinAttributes.cpp.inc:0:10
# | #11 0x00005a50c786e4b7 mlir::Builder::getIntegerAttr(mlir::Type, long) /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/include/llvm/ADT/APInt.h:0:7
# | #12 0x00005a50c766ca49 (anonymous namespace)::DepthwiseConvConverter::matchAndRewrite(mlir::tosa::DepthwiseConv2DOp, mlir::tosa::DepthwiseConv2DOpAdaptor, mlir::ConversionPatternRewriter&) const /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamed.cpp:0:35
# | #13 0x00005a50c766d541 mlir::OpConversionPattern<mlir::tosa::DepthwiseConv2DOp>::matchAndRewrite(mlir::tosa::DepthwiseConv2DOp, mlir::tosa::DepthwiseConv2DOpGenericAdaptor<llvm::ArrayRef<mlir::ValueRange>>, mlir::ConversionPatternRewriter&) const /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/include/mlir/Transforms/DialectConversion.h:716:12
# | #14 0x00005a50c766c1ba mlir::OpConversionPattern<mlir::tosa::DepthwiseConv2DOp>::matchAndRewrite(mlir::Operation*, llvm::ArrayRef<mlir::ValueRange>, mlir::ConversionPatternRewriter&) const /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/include/mlir/Transforms/DialectConversion.h:702:3
# | #15 0x00005a50c77df6a6 mlir::ConversionPattern::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&) const /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Transforms/Utils/DialectConversion.cpp:1871:10
# | #16 0x00005a50ca860922 operator() /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Rewrite/PatternApplicator.cpp:212:13
# | #17 0x00005a50ca860922 void llvm::function_ref<void ()>::callback_fn<mlir::PatternApplicator::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&, llvm::function_ref<bool (mlir::Pattern const&)>, llvm::function_ref<void (mlir::Pattern const&)>, llvm::function_ref<llvm::LogicalResult (mlir::Pattern const&)>)::$_0>(long) /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/include/llvm/ADT/STLFunctionalExtras.h:46:12
# | #18 0x00005a50ca85d63e mlir::PatternApplicator::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&, llvm::function_ref<bool (mlir::Pattern const&)>, llvm::function_ref<void (mlir::Pattern const&)>, llvm::function_ref<llvm::LogicalResult (mlir::Pattern const&)>) /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Rewrite/PatternApplicator.cpp:233:9
# | #19 0x00005a50c77e0712 (anonymous namespace)::OperationLegalizer::legalize(mlir::Operation*, mlir::ConversionPatternRewriter&) /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Transforms/Utils/DialectConversion.cpp:0:0
# | #20 0x00005a50c77df7b7 mlir::OperationConverter::convert(mlir::ConversionPatternRewriter&, mlir::Operation*) /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Transforms/Utils/DialectConversion.cpp:0:0
# | #21 0x00005a50c77e095f failed /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/include/llvm/Support/LogicalResult.h:43:43
# | #22 0x00005a50c77e095f failed /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/include/llvm/Support/LogicalResult.h:71:58
# | #23 0x00005a50c77e095f mlir::OperationConverter::convertOperations(llvm::ArrayRef<mlir::Operation*>) /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Transforms/Utils/DialectConversion.cpp:2677:9
# | #24 0x00005a50c77e6c8e applyFullConversion /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Transforms/Utils/DialectConversion.cpp:3381:22
# | #25 0x00005a50c77e6c8e mlir::applyFullConversion(mlir::Operation*, mlir::ConversionTarget const&, mlir::FrozenRewritePatternSet const&, mlir::ConversionConfig) /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Transforms/Utils/DialectConversion.cpp:3387:10
# | #26 0x00005a50c7663c65 (anonymous namespace)::TosaToLinalgNamed::runOnOperation() /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamedPass.cpp:74:16
# | #27 0x00005a50c777d203 operator() /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Pass/Pass.cpp:0:17
# | #28 0x00005a50c777d203 callback_fn<(lambda at /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Pass/Pass.cpp:521:7)> /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/include/llvm/ADT/STLFunctionalExtras.h:46:12
# | #29 0x00005a50c777d203 operator() /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/include/llvm/ADT/STLFunctionalExtras.h:69:12
# | #30 0x00005a50c777d203 executeAction<mlir::PassExecutionAction, mlir::Pass &> /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/include/mlir/IR/MLIRContext.h:280:7
# | #31 0x00005a50c777d203 mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int) /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Pass/Pass.cpp:520:21
# | #32 0x00005a50c777da82 failed /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/include/llvm/Support/LogicalResult.h:43:43
# | #33 0x00005a50c777da82 failed /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/include/llvm/Support/LogicalResult.h:71:58
# | #34 0x00005a50c777da82 mlir::detail::OpToOpPassAdaptor::runPipeline(mlir::OpPassManager&, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int, mlir::PassInstrumentor*, mlir::PassInstrumentation::PipelineParentInfo const*) /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Pass/Pass.cpp:592:9
# | #35 0x00005a50c7783f6e failed /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/include/llvm/Support/LogicalResult.h:43:43
...

```

</details>

https://github.com/llvm/llvm-project/pull/130282