[Mlir-commits] [mlir] [mlir][spirv] Add definition for selected sample operations (PR #129558)

[Andrea Faulds]

andfau-amd wrote:

General comment: why these three specifically? I can understand the logic to adding just the plain implicit and explicit LoD operations, as they're maybe the two most common and simplest sampling operations, but I'm not sure why you would also add just one operation out of the whole dref and proj family at the same time. I guess we strictly speaking do not have to add the whole set at once, but the piecemealness of it feels a little strange to me.

https://github.com/llvm/llvm-project/pull/129558