[Mlir-commits] [mlir] [mlir][TOSA] Fix linalg lowering of depthwise conv2d (PR #130282)

Fri Mar 7 05:32:36 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `mlir-rocm-mi200` running on `mi200-buildbot` while building `mlir` at step 7 "test-build-check-mlir-build-only-check-mlir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/177/builds/14202

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 7 (test-build-check-mlir-build-only-check-mlir) failure: test (failure)
******************** TEST 'MLIR :: Conversion/TosaToLinalg/tosa-to-linalg-named.mlir' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt --verify-each --split-input-file -pass-pipeline="builtin.module(func.func(tosa-to-linalg-named))" /vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir -verify-diagnostics -o -| /vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/FileCheck /vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir
# executed command: /vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt --verify-each --split-input-file '-pass-pipeline=builtin.module(func.func(tosa-to-linalg-named))' /vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir -verify-diagnostics -o -
# .---command stderr------------
# | <unknown>:0: error: unexpected error: expected integer or index type
# | mlir-opt: /vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/mlir/include/mlir/IR/StorageUniquerSupport.h:180: static ConcreteT mlir::detail::StorageUserBase<mlir::IntegerAttr, mlir::Attribute, mlir::detail::IntegerAttrStorage, mlir::detail::AttributeUniquer, mlir::TypedAttr::Trait>::get(MLIRContext *, Args &&...) [ConcreteT = mlir::IntegerAttr, BaseT = mlir::Attribute, StorageT = mlir::detail::IntegerAttrStorage, UniquerT = mlir::detail::AttributeUniquer, Traits = <mlir::TypedAttr::Trait>, Args = <mlir::Type &, const llvm::APInt &>]: Assertion `succeeded( ConcreteT::verifyInvariants(getDefaultDiagnosticEmitFn(ctx), args...))' failed.
# | PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
# | Stack dump:
# | 0.	Program arguments: /vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt --verify-each --split-input-file -pass-pipeline=builtin.module(func.func(tosa-to-linalg-named)) /vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir -verify-diagnostics -o -
# |  #0 0x0000562ede3b38d8 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x42f98d8)
# |  #1 0x0000562ede3b13ce llvm::sys::RunSignalHandlers() (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x42f73ce)
# |  #2 0x0000562ede3b40b6 SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
# |  #3 0x00007f40afcc8420 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x14420)
# |  #4 0x00007f40af78b00b raise (/lib/x86_64-linux-gnu/libc.so.6+0x4300b)
# |  #5 0x00007f40af76a859 abort (/lib/x86_64-linux-gnu/libc.so.6+0x22859)
# |  #6 0x00007f40af76a729 (/lib/x86_64-linux-gnu/libc.so.6+0x22729)
# |  #7 0x00007f40af77bfd6 (/lib/x86_64-linux-gnu/libc.so.6+0x33fd6)
# |  #8 0x0000562ee151b4c0 mlir::IntegerAttr::getChecked(llvm::function_ref<mlir::InFlightDiagnostic ()>, mlir::Type, llvm::APInt const&) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x74614c0)
# |  #9 0x0000562ee151b342 mlir::IntegerAttr::get(mlir::Type, llvm::APInt const&) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x7461342)
# | #10 0x0000562ee1516ee7 mlir::Builder::getIntegerAttr(mlir::Type, long) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x745cee7)
# | #11 0x0000562ee1318be9 (anonymous namespace)::DepthwiseConvConverter::matchAndRewrite(mlir::tosa::DepthwiseConv2DOp, mlir::tosa::DepthwiseConv2DOpAdaptor, mlir::ConversionPatternRewriter&) const TosaToLinalgNamed.cpp:0:0
# | #12 0x0000562ee13196e1 mlir::OpConversionPattern<mlir::tosa::DepthwiseConv2DOp>::matchAndRewrite(mlir::tosa::DepthwiseConv2DOp, mlir::tosa::DepthwiseConv2DOpGenericAdaptor<llvm::ArrayRef<mlir::ValueRange>>, mlir::ConversionPatternRewriter&) const TosaToLinalgNamed.cpp:0:0
# | #13 0x0000562ee131835a mlir::OpConversionPattern<mlir::tosa::DepthwiseConv2DOp>::matchAndRewrite(mlir::Operation*, llvm::ArrayRef<mlir::ValueRange>, mlir::ConversionPatternRewriter&) const TosaToLinalgNamed.cpp:0:0
# | #14 0x0000562ee14882e6 mlir::ConversionPattern::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&) const (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x73ce2e6)
# | #15 0x0000562ee44b4d02 void llvm::function_ref<void ()>::callback_fn<mlir::PatternApplicator::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&, llvm::function_ref<bool (mlir::Pattern const&)>, llvm::function_ref<void (mlir::Pattern const&)>, llvm::function_ref<llvm::LogicalResult (mlir::Pattern const&)>)::$_0>(long) PatternApplicator.cpp:0:0
# | #16 0x0000562ee44b19df mlir::PatternApplicator::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&, llvm::function_ref<bool (mlir::Pattern const&)>, llvm::function_ref<void (mlir::Pattern const&)>, llvm::function_ref<llvm::LogicalResult (mlir::Pattern const&)>) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0xa3f79df)
# | #17 0x0000562ee148936d (anonymous namespace)::OperationLegalizer::legalize(mlir::Operation*, mlir::ConversionPatternRewriter&) DialectConversion.cpp:0:0
# | #18 0x0000562ee1488407 mlir::OperationConverter::convert(mlir::ConversionPatternRewriter&, mlir::Operation*) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x73ce407)
# | #19 0x0000562ee14895bf mlir::OperationConverter::convertOperations(llvm::ArrayRef<mlir::Operation*>) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x73cf5bf)
# | #20 0x0000562ee148f6ee mlir::applyFullConversion(mlir::Operation*, mlir::ConversionTarget const&, mlir::FrozenRewritePatternSet const&, mlir::ConversionConfig) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x73d56ee)
# | #21 0x0000562ee1310059 (anonymous namespace)::TosaToLinalgNamed::runOnOperation() TosaToLinalgNamedPass.cpp:0:0
# | #22 0x0000562ee142630a mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x736c30a)
# | #23 0x0000562ee1426c12 mlir::detail::OpToOpPassAdaptor::runPipeline(mlir::OpPassManager&, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int, mlir::PassInstrumentor*, mlir::PassInstrumentation::PipelineParentInfo const*) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x736cc12)
# | #24 0x0000562ee142cd2e auto void mlir::parallelForEach<__gnu_cxx::__normal_iterator<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo*, std::vector<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo, std::allocator<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo>>>, mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::$_0>(mlir::MLIRContext*, __gnu_cxx::__normal_iterator<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo*, std::vector<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo, std::allocator<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo>>>, __gnu_cxx::__normal_iterator<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo*, std::vector<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo, std::allocator<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo>>>, mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::$_0&&)::'lambda'(__gnu_cxx::__normal_iterator<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo*, std::vector<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo, std::allocator<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo>>>&&)::operator()<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo&>(__gnu_cxx::__normal_iterator<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo*, std::vector<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo, std::allocator<mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo>>>&&) const Pass.cpp:0:0
# | #25 0x0000562ee142825b mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x736e25b)
# | #26 0x0000562ee1426463 mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x736c463)
# | #27 0x0000562ee1426c12 mlir::detail::OpToOpPassAdaptor::runPipeline(mlir::OpPassManager&, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int, mlir::PassInstrumentor*, mlir::PassInstrumentation::PipelineParentInfo const*) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x736cc12)
# | #28 0x0000562ee14291ee mlir::PassManager::run(mlir::Operation*) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x736f1ee)
# | #29 0x0000562ee14216eb performActions(llvm::raw_ostream&, std::shared_ptr<llvm::SourceMgr> const&, mlir::MLIRContext*, mlir::MlirOptMainConfig const&) MlirOptMain.cpp:0:0
# | #30 0x0000562ee1421205 llvm::LogicalResult llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>::callback_fn<mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&)::$_0>(long, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&) MlirOptMain.cpp:0:0
# | #31 0x0000562ee14dadf6 mlir::splitAndProcessBuffer(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>, llvm::raw_ostream&, llvm::StringRef, llvm::StringRef)::$_0::operator()(llvm::StringRef) const ToolUtilities.cpp:0:0
# | #32 0x0000562ee14daaaf mlir::splitAndProcessBuffer(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>, llvm::raw_ostream&, llvm::StringRef, llvm::StringRef) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x7420aaf)
# | #33 0x0000562ee141b2f2 mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x73612f2)
# | #34 0x0000562ee141b5a3 mlir::MlirOptMain(int, char**, llvm::StringRef, llvm::StringRef, mlir::DialectRegistry&) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x73615a3)
# | #35 0x0000562ee141b8be mlir::MlirOptMain(int, char**, llvm::StringRef, mlir::DialectRegistry&) (/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/bin/mlir-opt+0x73618be)
...

```

</details>

https://github.com/llvm/llvm-project/pull/130282