[Mlir-commits] [mlir] [mlir][tosa] Convert RESCALE op multiplier and shift from attributes to inputs (PR #129720)

[Peng Sun]

================
@@ -2469,6 +2468,139 @@ LogicalResult TransposeConv2DOp::verify() {
   return success();
 }
 
+LogicalResult RescaleOp::verify() {
+  auto inputType = llvm::dyn_cast<ShapedType>(getInput().getType());
+  if (!inputType) {
+    emitOpError("expect shaped tensor for input, got ") << getInput().getType();
----------------
psunn wrote:

The use of error guard of `llvm::dyn_cast<ShapedType>` is consistent throughout MLIR, so I’d prefer to keep it as it is.
Please let me know if I missed anything here.

https://github.com/llvm/llvm-project/pull/129720