[Mlir-commits] [mlir] [mlir][DataLayout] Add a default memory space entry to the data layout. (PR #127416)

[Fabian Mora]

================
@@ -318,7 +318,8 @@ combineOneSpec(DataLayoutSpecInterface spec,
            "unexpected data layout entry for built-in type");
 
     auto interface = cast<DataLayoutTypeInterface>(typeSample);
-    if (!interface.areCompatible(entriesForType.lookup(kvp.first), kvp.second))
+    if (!interface.areCompatible(entriesForType.lookup(kvp.first), kvp.second,
----------------
fabianmcg wrote:

@rolfmorel In the last commit I pushed I'm using `entriesForID`, see https://github.com/llvm/llvm-project/pull/127416/commits/9f505ec0acc28d80d9aa2ed07ef1fbb7b9e43a13#diff-4f5499b7fdbe03b91d0387fb56ff2e32e3528c929289e148cebdb4d18546033bR343-R344 .

However, I also need to pass the spec to be able to query the interface method `getDefaultMemorySpaceIdentifier`. (newSpec contains the correct instance of the method)

I think in a future we need to take a second look at identified entries.

https://github.com/llvm/llvm-project/pull/127416