[Mlir-commits] [mlir] [mlir][DataLayout] Add a default memory space entry to the data layout. (PR #127416)

[Rolf Morel]

================
@@ -318,7 +318,8 @@ combineOneSpec(DataLayoutSpecInterface spec,
            "unexpected data layout entry for built-in type");
 
     auto interface = cast<DataLayoutTypeInterface>(typeSample);
-    if (!interface.areCompatible(entriesForType.lookup(kvp.first), kvp.second))
+    if (!interface.areCompatible(entriesForType.lookup(kvp.first), kvp.second,
----------------
rolfmorel wrote:

Having had look at `combineWith`, the sole user of `combineOneSpec`, I am quite sure that `entriesForId` should be in the right combined state - w.r.t. the current `spec` and all prior `spec`s that have already be combined into `entriesForId` - when it becomes time for you to call `areCompatible()` for the types. 

@fabianmcg, could you check this, and if this the case update the interface of `areCompatible` accordingly? This is my only remaining concern.

Apologies for the protracted discussion on this point - the whole thing is a bit intricate. I am just trying to make sure that that doesn't leak into the interfaces.

https://github.com/llvm/llvm-project/pull/127416