[Mlir-commits] [mlir] [mlir] Allow trailing digit for alias in AsmPrinter (PR #127993)

[River Riddle]

================
@@ -1079,12 +1073,43 @@ void AliasInitializer::initializeAliases(
     return lhs.second < rhs.second;
   });
 
+  // This keeps track of all of the non-numeric names that are in flight,
+  // allowing us to check for duplicates.
+  llvm::BumpPtrAllocator usedAliasAllocator;
+  llvm::StringSet<llvm::BumpPtrAllocator &> usedAliases(usedAliasAllocator);
+
   llvm::StringMap<unsigned> nameCounts;
   for (auto &[symbol, aliasInfo] : unprocessedAliases) {
     if (!aliasInfo.alias)
       continue;
     StringRef alias = *aliasInfo.alias;
-    unsigned nameIndex = nameCounts[alias]++;
+    // Get nameIndex that will not generate conflicting name.
+    unsigned nameIndex = 0;
+    if (!usedAliases.count(alias)) {
+      usedAliases.insert(alias);
+    } else {
+      // Otherwise, we had a conflict - probe until we find a unique name.
+      SmallString<64> probeAlias(alias);
+      // alias with trailing digit will be printed as _N
+      if (isdigit(alias.back())) {
----------------
River707 wrote:

Please drop trivial braces here and below.

https://github.com/llvm/llvm-project/pull/127993