[Mlir-commits] [mlir] [MLIR][LLVMIR] llvm.call_intrinsic: support operand/result attributes (PR #129640)

[Tobias Gysi]

gysit wrote:

> The problem is the actual lack of OperationState being available to pass in to both addArgAndResultAttrs and parseCallTypeAndResolveOperands. I think we might be able to keep the assemblyFormat if strip some of the guts from both into smaller ones and use them into the custom parse/print function. Maybe it's possible to add those smaller things to call_interface_impl, not sure. If we wanna keep the assemblyFormat, some small dup could be the tradeoff (it might not work also, let's see). Wdyt?

Yeah we probably would like to have something that just parses the call type and does not try to resolve the operands. AFAIK the code to resolve the call types should be generated by tablegen when using an assembly format.

I would suggest to move forward with what we have for now. We can still follow up with an assembly format version if we want to.

https://github.com/llvm/llvm-project/pull/129640