[Mlir-commits] [mlir] [mlir][tosa] Make RESCALE op input_unsigned and output_unsigned attributes required (PR #129339)

[Luke Hutton]

================
@@ -165,13 +165,18 @@ ConvertTosaConv2DOp::matchAndRewrite(Operation *op,
   // Obtain the quantized scale = multiplier and shift.
   computeMultiplierAndShift(opTensorScale, multiplier, shift, 32);
 
+  bool input_unsigned =
+      newTosaConv2DOp.getResult().getType().isUnsignedInteger();
+  bool output_unsigned = outputType.isUnsignedInteger();
+
----------------
lhutton1 wrote:

Nit: does `outputType == newTosaConv2DOp.getResult().getType()` here?

https://github.com/llvm/llvm-project/pull/129339